Implementation Inspection Checklist#
Implementation Inspection Checklist Template
|
status: valid
|
||||
Purpose#
The purpose of this checklist is to collect the topics to be checked during implementation, i.e. in the detailed design and the source code of the units.
The checklist shall be agnostic to which programming language is used. Differences shall be treated by linking to C++ or Rust specific documentation.
Checklist#
Review ID |
Acceptance Criteria |
Guidance |
Passed |
Remarks |
Issue link |
---|---|---|---|---|---|
IMPL_01_01 |
Is the design according to guidelines? |
see Detailed Design Templates (gd_temp__detailed_design) and Concept Description (doc_concept__imp__concept) (e.g. are the views done with the proposed UML diagrams) |
|||
IMPL_01_02 |
Are the SOLID design principles applied? |
The Unit Design shall archieve the following principles: Correct order of excecution of the functions, consistency of the interfaces between the units, correctness of data flow and data controll between the units, simplicity, readability and comprehensibility, robustness, suitability for modifications, verifiability |
|||
IMPL_01_03 |
Is the implementation according to specification? |
Check if the linked component requirements are fulfilled and detailed design also matches architecture description. |
|||
IMPL_01_04 |
Are the design decisions and constraints documented? |
Check also for plausibility of these. |
|||
IMPL_01_05 |
Are all external libraries used by the component specified in the detailed design? |
Check the automated dependency analysis. Also make sure ASIL rated units also only use ASIL or FFI rated libraries. |
|||
IMPL_02_01 |
Are the static and dynamic code analysis reports verified for violations? |
All violations in ASIL related code must be justified. This includes the checks of coding guidelines. |
|||
IMPL_02_02 |
Do manual checks, that are derived from the coding guideline, find no safety critical error? |
Check this list for C++ <link> and this list for Rust <link> |
|||
IMPL_02_03 |
Are detailed design and source code consistent? |
Check if the static and dynamic design descriptions match the code (e..g. naming of elements) and that the respective traceability is established (doxygen style comments) |